maedhroz commented on a change in pull request #1301:
URL: https://github.com/apache/cassandra/pull/1301#discussion_r796255062
##########
File path: src/java/org/apache/cassandra/utils/JVMStabilityInspector.java
##########
@@ -140,15 +140,26 @@ else if (t instanceof UnrecoverableIllegalStateException)
if (t instanceof FSError || t instanceof CorruptSSTableException)
isUnstable = true;
- fn.accept(t);
-
// Check for file handle exhaustion
if (t instanceof FileNotFoundException || t instanceof
FileSystemException || t instanceof SocketException)
if (t.getMessage() != null && t.getMessage().contains("Too many
open files"))
isUnstable = true;
if (isUnstable)
+ {
+ if (!StorageService.instance.isDaemonSetupCompleted())
+ FileUtils.handleStartupFSError(t);
killer.killCurrentJVM(t);
+ }
+
+ try
+ {
+ fn.accept(t);
+ }
+ catch (Exception | Error e)
+ {
+ logger.warn("Unexpected error while handling unexpected error", e);
+ }
Review comment:
Are the changes in `inspectThrowable()` accounted for in a test
anywhere? It doesn't seem to affect any of the tests the patch touches if I
move `accept()` back up to its former location...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
