maedhroz commented on a change in pull request #1301:
URL: https://github.com/apache/cassandra/pull/1301#discussion_r796271099
##########
File path: src/java/org/apache/cassandra/db/streaming/CassandraStreamReader.java
##########
@@ -136,10 +143,10 @@ public SSTableMultiWriter read(DataInputPlus inputPlus)
throws IOException
logger.warn("[Stream {}] Error while reading partition {} from
stream on ks='{}' and table='{}'.",
session.planId(), partitionKey,
cfs.keyspace.getName(), cfs.getTableName(), e);
if (writer != null)
- {
- writer.abort(e);
- }
- throw Throwables.propagate(e);
+ e = writer.abort(e);
+ Throwables.throwIfUnchecked(e);
+ Throwables.throwIfInstanceOf(e, Exception.class);
+ throw new RuntimeException(e); // not possible; just here to
compile
Review comment:
If we did that, we could also revert the methods in the `IncomingStream`
hierarchy to keep `throws IOException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
