maedhroz commented on a change in pull request #1301:
URL: https://github.com/apache/cassandra/pull/1301#discussion_r796270290
##########
File path:
src/java/org/apache/cassandra/streaming/messages/IncomingStreamMessage.java
##########
@@ -44,18 +43,19 @@ public IncomingStreamMessage deserialize(DataInputPlus
input, int version) throw
ColumnFamilyStore cfs =
ColumnFamilyStore.getIfExists(header.tableId);
if (cfs == null)
throw new StreamReceiveException(session, "CF " +
header.tableId + " was dropped during streaming");
-
try
{
IncomingStream incomingData =
cfs.getStreamManager().prepareIncomingStream(session, header);
incomingData.read(input, version);
return new IncomingStreamMessage(incomingData, header);
}
- catch (Throwable t)
+ catch (Exception | Error e)
Review comment:
Not using `Throwable` because you want to exclude non `java.lang`
subclasses?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
