maedhroz commented on a change in pull request #1301:
URL: https://github.com/apache/cassandra/pull/1301#discussion_r796276192
##########
File path: src/java/org/apache/cassandra/streaming/StreamSession.java
##########
@@ -837,14 +846,11 @@ public synchronized void complete()
{
logger.debug("[Stream #{}] handling Complete message, state = {}",
planId(), state);
- if (!isFollower)
+ if (!isFollower) // initiator
{
- if (state == State.WAIT_COMPLETE)
- closeSession(State.COMPLETE);
- else
- state(State.WAIT_COMPLETE);
+ initiatorCompleteOrWait();
}
- else
+ else // follower
Review comment:
nit: Perhaps we should just reverse the order of the if/else conditions
here (and in a few others place) and avoid the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
