maedhroz commented on a change in pull request #1301:
URL: https://github.com/apache/cassandra/pull/1301#discussion_r796268321
##########
File path: src/java/org/apache/cassandra/net/AsyncStreamingInputPlus.java
##########
@@ -115,7 +115,8 @@ protected void reBuffer() throws ClosedChannelException,
InputTimeoutException
if (queue.isEmpty())
channel.read();
- currentBuf.release();
+ if (currentBuf != null)
Review comment:
If that happens, is there any case where we don't immediately call
`close()` (which does check to see if the `currentBuf` is `null`)? I'm just a
little worried that we actually shouldn't ever try to `reBuffer()` after that
happens, and not throwing a runtime exception if that happens is actually the
opposite of what we want...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
