belliottsmith commented on code in PR #10:
URL: https://github.com/apache/cassandra-accord/pull/10#discussion_r976533682
##########
accord-core/src/main/java/accord/api/Read.java:
##########
@@ -29,5 +35,42 @@
public interface Read
{
Keys keys();
- Data read(Key key, Timestamp executeAt, DataStore store);
+ Future<Data> read(Key key, CommandStore commandStore, Timestamp executeAt,
DataStore store);
+
+ class ReadFuture extends AsyncPromise<Data> implements BiConsumer<Data,
Throwable>
Review Comment:
Should this extend `SyncPromise` since it appears to be synchronous? Or
perhaps `AbstractFuture` with no synchronisation (since we should probably be
invoking callbacks on the home shard `CommandStore`)
I think it would also be preferable not to have this defined in the
interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
