belliottsmith commented on code in PR #10:
URL: https://github.com/apache/cassandra-accord/pull/10#discussion_r976535381
##########
accord-core/src/main/java/accord/api/Write.java:
##########
@@ -27,5 +30,6 @@
*/
public interface Write
{
- void apply(Key key, Timestamp executeAt, DataStore store);
+ Future<Void> SUCCESS = ImmediateFuture.success(null);
Review Comment:
Again, not sure it is a great idea to put this in the interface, this case
more so as it potentially breaks the simulator in future by pulling in
implementation classes alongside interface classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
