belliottsmith commented on code in PR #10:
URL: https://github.com/apache/cassandra-accord/pull/10#discussion_r985143125
##########
accord-core/src/main/java/accord/primitives/KeyRanges.java:
##########
@@ -27,22 +28,24 @@
import java.util.*;
import static accord.utils.SortedArrays.Search.FAST;
+import static accord.utils.Utils.toArray;
public class KeyRanges implements Iterable<KeyRange>
{
public static final KeyRanges EMPTY = ofSortedAndDeoverlappedUnchecked(new
KeyRange[0]);
final KeyRange[] ranges;
- private KeyRanges(KeyRange[] ranges)
+ @VisibleForImplementation
Review Comment:
Why is this being made public? Can we use the static constructor methods
that enforce the constraints?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
