belliottsmith commented on code in PR #10:
URL: https://github.com/apache/cassandra-accord/pull/10#discussion_r985269448
##########
accord-core/src/main/java/accord/primitives/Deps.java:
##########
@@ -1022,15 +1049,27 @@ public TxnId txnId(int i)
return txnIds[i];
}
+ @VisibleForImplementation
+ public int keyToTxnIdCount()
+ {
+ return keyToTxnId.length;
+ }
+
+ @VisibleForImplementation
+ public int keyToTxnId(int idx)
Review Comment:
Perhaps prefix with `unsafe` or `serialization` as this is only for
serialisation, and is not to be interpreted directly? As named it might be
misinterpreted as a function for external use, which would be unlikely to go
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
