belliottsmith commented on code in PR #10:
URL: https://github.com/apache/cassandra-accord/pull/10#discussion_r989928601
##########
accord-core/src/main/java/accord/primitives/Deps.java:
##########
@@ -388,7 +390,8 @@ public static <T> Deps merge(List<T> merge, Function<T,
Deps> getter)
// Lazy loaded in ensureTxnIdToKey()
int[] txnIdToKey; // TxnId -> [Key]
- Deps(Keys keys, TxnId[] txnIds, int[] keyToTxnId)
+ @VisibleForImplementation
Review Comment:
Perhaps let's add one prefixed by `unsafe`? At present we ensure we impose
our constraints (per @dcapwell's excellent feedback on my earlier patch) and it
would be a shame to make it again easy to bypass accidentally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
