belliottsmith commented on code in PR #17:
URL: https://github.com/apache/cassandra-accord/pull/17#discussion_r1051331638
##########
accord-core/src/main/java/accord/coordinate/Recover.java:
##########
@@ -93,24 +91,24 @@ public void onCallbackFailure(Id from, Throwable failure)
}
}
- Future<Object> awaitCommits(Node node, Deps waitOn)
+ AsyncResult<Object> awaitCommits(Node node, Deps waitOn)
{
AtomicInteger remaining = new AtomicInteger(waitOn.txnIdCount());
- Promise<Object> future = new AsyncPromise<>();
+ AsyncResult.Settable<Object> notifier = AsyncResults.settable();
Review Comment:
That’s the same here? The AsyncResult hides it, the Settable exposes it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
