belliottsmith commented on code in PR #17:
URL: https://github.com/apache/cassandra-accord/pull/17#discussion_r1052420104
##########
accord-core/src/main/java/accord/coordinate/Recover.java:
##########
@@ -93,24 +91,24 @@ public void onCallbackFailure(Id from, Throwable failure)
}
}
- Future<Object> awaitCommits(Node node, Deps waitOn)
+ AsyncResult<Object> awaitCommits(Node node, Deps waitOn)
{
AtomicInteger remaining = new AtomicInteger(waitOn.txnIdCount());
- Promise<Object> future = new AsyncPromise<>();
+ AsyncResult.Settable<Object> notifier = AsyncResults.settable();
for (int i = 0 ; i < waitOn.txnIdCount() ; ++i)
{
TxnId txnId = waitOn.txnId(i);
// TODO (now): this should perhaps use RouteFragment as we might
need to handle txns that are range-only
new AwaitCommit(node, txnId,
waitOn.someRoutables(txnId)).addCallback((success, failure) -> {
- if (future.isDone())
+ if (notifier.isDone())
Review Comment:
result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
