belliottsmith commented on code in PR #17:
URL: https://github.com/apache/cassandra-accord/pull/17#discussion_r1053196364
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -730,7 +734,7 @@ public void accept(SafeCommandStore safeStore)
if (cur == null)
{
// need to load; schedule execution for later
- safeStore.execute(this, this);
+ safeStore.execute(this,
this).begin(AsyncCallbacks.throwOnFailure());
Review Comment:
This seems quite similar to the pattern of invoking with the `node.agent()`.
I'm down with standardising this to some global singleton that handles
propagating exceptions, but let's do it across the board. Perhaps we want to
call it `logErrors` or something else, that makes it clearer what's happening?
Though don't hate `noOp`, and don't mind terribly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
