belliottsmith commented on code in PR #17: URL: https://github.com/apache/cassandra-accord/pull/17#discussion_r1052970858
########## accord-core/src/main/java/accord/utils/async/AsyncResult.java: ########## @@ -0,0 +1,96 @@ +package accord.utils.async; + +import java.util.concurrent.Executor; +import java.util.function.BiConsumer; + +/** + * Handle for async computations that supports multiple listeners and registering + * listeners after the computation has started + */ +public interface AsyncResult<V> Review Comment: Wdym more cas/volatile overhead? There should be no more overhead in this regard. If there is, it’s a mistake and we should fix it. Slightly different code performing the exact same work is code duplication? Not having multiple hops today says nothing about the future? If you want to do chaining of AsyncResult, it would probably be better to have Future implement AshncResult and convert to Future, since at this point you are not saving anything with the separate concept. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
