belliottsmith commented on code in PR #17: URL: https://github.com/apache/cassandra-accord/pull/17#discussion_r1052982178
########## accord-core/src/main/java/accord/utils/async/AsyncResult.java: ########## @@ -0,0 +1,96 @@ +package accord.utils.async; + +import java.util.concurrent.Executor; +import java.util.function.BiConsumer; + +/** + * Handle for async computations that supports multiple listeners and registering + * listeners after the computation has started + */ +public interface AsyncResult<V> Review Comment: Yep, there should only be two CAS, same as we would need to directly transform. One to register the callback on the old AsyncResult, and one to set the new AsyncResult outcome. We have two intermediate objects: the Head (which is hopefully stack allocated), the Map node, and then the AsyncResult itself. So, is it the Map node you want to remove by merging with AsyncResult in the other case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
