Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1057988703
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -1747,10 +1767,10 @@ public static InetAddressAndPort getReplaceAddress()
{
try
{
- if (System.getProperty(Config.PROPERTY_PREFIX + "replace_address",
null) != null)
- return
InetAddressAndPort.getByName(System.getProperty(Config.PROPERTY_PREFIX +
"replace_address", null));
- else if (System.getProperty(Config.PROPERTY_PREFIX +
"replace_address_first_boot", null) != null)
- return
InetAddressAndPort.getByName(System.getProperty(Config.PROPERTY_PREFIX +
"replace_address_first_boot", null));
+ if (REPLACE_ADDRESS.getString(null) != null)
Review Comment:
I was done it intentionally to simplify the review. The whole PR is quite
big, so even small refactoring may increase total complexity.
I totally agree here.
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
