Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1057990591
##########
src/java/org/apache/cassandra/db/compaction/TimeWindowCompactionStrategyOptions.java:
##########
@@ -153,8 +154,8 @@ public static Map<String, String>
validateOptions(Map<String, String> options, M
if (!(optionValue.equalsIgnoreCase("true") ||
optionValue.equalsIgnoreCase("false")))
throw new ConfigurationException(String.format("%s is not
'true' or 'false' (%s)", UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_KEY,
optionValue));
- if(optionValue.equalsIgnoreCase("true") &&
!Boolean.getBoolean(UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_PROPERTY))
- throw new ConfigurationException(String.format("%s is
requested but not allowed, restart cassandra with -D%s=true to allow it",
UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_KEY,
UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_PROPERTY));
+ if(optionValue.equalsIgnoreCase("true") &&
!UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_ENABLED)
+ throw new ConfigurationException(String.format("%s is
requested but not allowed, restart cassandra with -D%s=true to allow it",
UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_KEY,
ALLOW_UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION.getKey()));
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
