Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1058005560
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -689,9 +702,9 @@ private static Collection<Token>
validateReplacementBootstrapTokens(TokenMetadat
public synchronized void checkForEndpointCollision(UUID localHostId,
Set<InetAddressAndPort> peers) throws ConfigurationException
{
- if (Boolean.getBoolean("cassandra.allow_unsafe_join"))
+ if (ALLOW_UNSAFE_JOIN.getBoolean())
{
- logger.warn("Skipping endpoint collision check as
cassandra.allow_unsafe_join=true");
+ logger.warn("Skipping endpoint collision check as " +
ALLOW_UNSAFE_JOIN.getBoolean() + "=true");
Review Comment:
Good catch. My bad.
Fixed.
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -921,7 +934,7 @@ public boolean isReplacing()
if (replacing)
return true;
- if (System.getProperty("cassandra.replace_address_first_boot", null)
!= null && SystemKeyspace.bootstrapComplete())
+ if (REPLACE_ADDRESS_FIRST_BOOT.getString(null) != null &&
SystemKeyspace.bootstrapComplete())
{
logger.info("Replace address on first boot requested; this node is
already bootstrapped");
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
