Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1058005451
##########
src/java/org/apache/cassandra/service/CassandraDaemon.java:
##########
@@ -699,8 +704,8 @@ public void start()
private void startClientTransports()
{
- String nativeFlag =
System.getProperty("cassandra.start_native_transport");
- if ((nativeFlag != null && Boolean.parseBoolean(nativeFlag)) ||
(nativeFlag == null && DatabaseDescriptor.startNativeTransport()))
+ String nativeFlag = START_NATIVE_TRANSPORT.getString();
+ if ((Boolean.parseBoolean(nativeFlag)) || (nativeFlag == null &&
DatabaseDescriptor.startNativeTransport()))
Review Comment:
You're right.
Fixed.
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -328,9 +341,9 @@ public enum Mode { STARTING, NORMAL, JOINING, LEAVING,
DECOMMISSIONED, MOVING, D
private Collection<Token> bootstrapTokens = null;
// true when keeping strict consistency while bootstrapping
- public static final boolean useStrictConsistency =
Boolean.parseBoolean(System.getProperty("cassandra.consistent.rangemovement",
"true"));
- private static final boolean allowSimultaneousMoves =
Boolean.parseBoolean(System.getProperty("cassandra.consistent.simultaneousmoves.allow","false"));
- private static final boolean joinRing =
Boolean.parseBoolean(System.getProperty("cassandra.join_ring", "true"));
+ public static final boolean useStrictConsistency =
CONSISTENT_RANGEMOVEMENT.getBoolean();
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
