Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1057990998
##########
src/java/org/apache/cassandra/db/compaction/TimeWindowCompactionStrategyOptions.java:
##########
@@ -153,8 +154,8 @@ public static Map<String, String>
validateOptions(Map<String, String> options, M
if (!(optionValue.equalsIgnoreCase("true") ||
optionValue.equalsIgnoreCase("false")))
throw new ConfigurationException(String.format("%s is not
'true' or 'false' (%s)", UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_KEY,
optionValue));
- if(optionValue.equalsIgnoreCase("true") &&
!Boolean.getBoolean(UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_PROPERTY))
- throw new ConfigurationException(String.format("%s is
requested but not allowed, restart cassandra with -D%s=true to allow it",
UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_KEY,
UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_PROPERTY));
+ if(optionValue.equalsIgnoreCase("true") &&
!UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_ENABLED)
Review Comment:
Fixed.
##########
src/java/org/apache/cassandra/db/marshal/EmptyType.java:
##########
@@ -46,13 +48,12 @@ public class EmptyType extends AbstractType<Void>
private enum NonEmptyWriteBehavior { FAIL, LOG_DATA_LOSS, SILENT_DATA_LOSS
}
private static final Logger logger =
LoggerFactory.getLogger(EmptyType.class);
- private static final String KEY_EMPTYTYPE_NONEMPTY_BEHAVIOR =
"cassandra.serialization.emptytype.nonempty_behavior";
private static final NoSpamLogger NON_EMPTY_WRITE_LOGGER =
NoSpamLogger.getLogger(logger, 1, TimeUnit.MINUTES);
private static final NonEmptyWriteBehavior NON_EMPTY_WRITE_BEHAVIOR =
parseNonEmptyWriteBehavior();
private static NonEmptyWriteBehavior parseNonEmptyWriteBehavior()
{
- String value = System.getProperty(KEY_EMPTYTYPE_NONEMPTY_BEHAVIOR);
+ String value = SERIALIZATION_EMPTYTYPE_NONEMPTY_BEHAVIOR.getString();
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
