aweisberg commented on code in PR #26:
URL: https://github.com/apache/cassandra-accord/pull/26#discussion_r1094859003
##########
accord-core/src/main/java/accord/messages/BeginRecovery.java:
##########
@@ -152,16 +164,18 @@ public RecoverReply reduce(RecoverReply r1, RecoverReply
r2)
if (!ok1.status.hasBeen(PreAccepted)) throw new
IllegalStateException();
PartialDeps deps = ok1.deps.with(ok2.deps);
+ PartialDeps acceptedDeps = ok1.deps == ok1.acceptedDeps && ok2.deps ==
ok2.acceptedDeps ? deps : ok1.acceptedDeps.with(ok2.acceptedDeps);
Review Comment:
Ok, it took me a minute. What this is doing is creating the accepted deps
only if it has to because it's not the same as `deps` when one or more has
returned `NONE` for accepted deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
