aweisberg commented on code in PR #26:
URL: https://github.com/apache/cassandra-accord/pull/26#discussion_r1094839344
##########
accord-core/src/main/java/accord/primitives/Txn.java:
##########
@@ -32,13 +32,26 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
-import static accord.primitives.Routables.Slice.Overlapping;
-
public interface Txn
{
enum Kind
{
- Read, Write;
+ Read,
+ Write,
+
+ /**
+ * A pseudo-transaction whose deps represent the complete set of
transactions that may execute before it,
+ * without interfering with their execution.
+ *
+ * A SyncPoint is unique in that it agrees not only an executeAt but
also a precise collection of dependencies,
Review Comment:
I still don't follow something basic. What does agree mean?
Maybe we need to step up a level and explain how a sync point achieves its
objective where when a result is returned all the dependencies of this txn have
reached applied.
Maybe I am crazy, but it looks like the callback fires after `Propose`
completes, and doesn't wait for the dependencies to actually apply?
I am going to reread again today and see if I can get to a better
understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
