belliottsmith commented on code in PR #26:
URL: https://github.com/apache/cassandra-accord/pull/26#discussion_r1093764809
##########
accord-core/src/main/java/accord/primitives/Txn.java:
##########
@@ -32,13 +32,26 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
-import static accord.primitives.Routables.Slice.Overlapping;
-
public interface Txn
{
enum Kind
{
- Read, Write;
+ Read,
+ Write,
+
+ /**
+ * A pseudo-transaction whose deps represent the complete set of
transactions that may execute before it,
+ * without interfering with their execution.
+ *
+ * A SyncPoint is unique in that it agrees not only an executeAt but
also a precise collection of dependencies,
Review Comment:
Nope, most transactions do not _agree_ their deps, and indeed for those that
agree with 1RT consensus there are no durable deps to recover (and we intend to
stop supplying them for accept too). But for SyncPoint, for the reasons stated
elsewhere, this is fine because we always have `executeAt=txnId` and this is
fine because we don't "execute" them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
