adelapena commented on code in PR #2310: URL: https://github.com/apache/cassandra/pull/2310#discussion_r1223089676
########## test/unit/org/apache/cassandra/cql3/validation/operations/CQLVectorTest.java: ########## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3.validation.operations; + +import org.junit.Test; + +import org.apache.cassandra.cql3.CQLTester; + +public class CQLVectorTest extends CQLTester.InMemory Review Comment: I think we should probably add some tests for functions. For example, the following doesn't work: ```java @Test public void functions() { VectorType<Integer> type = VectorType.getInstance(Int32Type.instance, 2); Vector<Integer> vector = vector(1, 2); NativeFunctions.instance.add(new NativeScalarFunction("f", type, type) { @Override public ByteBuffer execute(ProtocolVersion protocol, List<ByteBuffer> parameters) { return parameters.get(0); } }); createTable(KEYSPACE, "CREATE TABLE %s (pk int primary key, value vector<int, 2>)"); execute("INSERT INTO %s (pk, value) VALUES (0, ?)", vector); assertRows(execute("SELECT f(value) FROM %s WHERE pk=0"), row(vector)); assertRows(execute("SELECT f([1, 2]) FROM %s WHERE pk=0"), row(vector)); } ``` It throws `Type error: [1, 2] cannot be passed as argument 0 of function system.f of type vector<int, 2>`. That's because the terminal argument in the second function call is a `Selectable.WithList`, and that selectable refuses to be assigned to the vector type. That happens in `Selectable.WithList#testAssignment`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
