dcapwell commented on code in PR #2310:
URL: https://github.com/apache/cassandra/pull/2310#discussion_r1223288259
##########
src/java/org/apache/cassandra/db/marshal/ValueAccessor.java:
##########
@@ -311,6 +319,24 @@ default boolean getBoolean(V value, int offset)
int toInt(V value);
/** returns an int from offset {@param offset} */
int getInt(V value, int offset);
+ default long getUnsignedVInt(V value, int offset)
+ {
+ return VIntCoding.getUnsignedVInt(value, this, offset);
+ }
+ default int getUnsignedVInt32(V value, int offset)
+ {
+ return VIntCoding.getUnsignedVInt32(value, this, offset);
+ }
+ default long getVInt(V value, int offset)
+ {
+ return VIntCoding.getVInt(value, this, offset);
+ }
+ default int getVInt32(V value, int offset)
+ {
+ return VIntCoding.getVInt32(value, this, offset);
+ }
Review Comment:
just created property tests for each method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
