dcapwell commented on code in PR #2310:
URL: https://github.com/apache/cassandra/pull/2310#discussion_r1223256407
##########
src/java/org/apache/cassandra/db/NativeClustering.java:
##########
@@ -45,7 +46,7 @@ public NativeClustering(NativeAllocator allocator,
OpOrder.Group writeOp, Cluste
int bitmapSize = ((count + 7) >>> 3);
assert count < 64 << 10;
- assert dataSize < 64 << 10;
+ assert dataSize <= FBUtilities.MAX_UNSIGNED_SHORT :
String.format("Data size %d >= %d", dataSize, FBUtilities.MAX_UNSIGNED_SHORT +
1);
Review Comment:
this shouldn't happen anymore as I added this check earlier in the
pipeline... found some fun bugs with composite partitions where the values are
> `Short.MAX_VALUE` and seems I had to be careful how we defend against it as
composite columns allow things non-composite columns don't! (you can have
empty values when `PRIMARY KEY((a, b))` but not `PRIMARY KEY(a)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
