belliottsmith commented on code in PR #50:
URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1239482046
##########
accord-core/src/main/java/accord/utils/ReducingIntervalMap.java:
##########
@@ -93,35 +99,47 @@ public boolean equals(Object o)
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
ReducingIntervalMap that = (ReducingIntervalMap) o;
- return Arrays.equals(ends, that.ends) && Arrays.equals(values,
that.values);
+ return Arrays.equals(starts, that.starts) && Arrays.equals(values,
that.values);
}
public int hashCode()
{
return Arrays.hashCode(values);
Review Comment:
Also, hashCode() does not need to include everything, no. It just needs to
be the case that equals() => equal hashCode()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
