bdeggleston commented on code in PR #49:
URL: https://github.com/apache/cassandra-accord/pull/49#discussion_r1228461824
##########
accord-core/src/main/java/accord/impl/InMemoryCommandStore.java:
##########
@@ -461,6 +461,19 @@ void update(Ranges add)
}
}
+ public AsyncChain<Timestamp> maxAppliedFor(Seekables<?, ?> keysOrRanges,
Ranges slice)
+ {
+ Seekables<?, ?> sliced = keysOrRanges.slice(slice, Minimal);
+ Timestamp timestamp = Timestamp.NONE;
+ for (GlobalCommand globalCommand : commands.values())
Review Comment:
I believe that's intentional, since we're only interested in commands that
have been applied to disk and range txns are (currently) only used as markers
##########
accord-core/src/main/java/accord/impl/InMemoryCommandStore.java:
##########
@@ -461,6 +461,19 @@ void update(Ranges add)
}
}
+ public AsyncChain<Timestamp> maxAppliedFor(Seekables<?, ?> keysOrRanges,
Ranges slice)
+ {
+ Seekables<?, ?> sliced = keysOrRanges.slice(slice, Minimal);
+ Timestamp timestamp = Timestamp.NONE;
+ for (GlobalCommand globalCommand : commands.values())
Review Comment:
I believe that's intentional, since we're only interested in commands that
have been applied to disk and range txns are (currently) only used as
markers/sync points/etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
