dcapwell commented on code in PR #49:
URL: https://github.com/apache/cassandra-accord/pull/49#discussion_r1228507832
##########
accord-core/src/main/java/accord/impl/InMemoryCommandStore.java:
##########
@@ -461,6 +461,19 @@ void update(Ranges add)
}
}
+ public AsyncChain<Timestamp> maxAppliedFor(Seekables<?, ?> keysOrRanges,
Ranges slice)
+ {
+ Seekables<?, ?> sliced = keysOrRanges.slice(slice, Minimal);
+ Timestamp timestamp = Timestamp.NONE;
+ for (GlobalCommand globalCommand : commands.values())
Review Comment:
> range txns are (currently) only used as markers/sync points/etc
The only caller atm is
`org.apache.cassandra.service.accord.AccordFetchCoordinator` (outside of
tests), which is focused on streaming user data... so unless we have range
write support (think we only plan for range read?), then the only data present
should be from key commands... so excluding range commands should be fine in
this context...
So, assuming that we do only care about what data was applied to user tables
in this context, don't we also want to filter out non-write txn?
`org.apache.cassandra.service.accord.AccordCommandStore#maxApplied` does, but
not `accord.impl.InMemoryCommandStore#maxAppliedFor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
