dcapwell commented on code in PR #49:
URL: https://github.com/apache/cassandra-accord/pull/49#discussion_r1228540430
##########
accord-core/src/main/java/accord/local/CommandStore.java:
##########
@@ -128,6 +128,8 @@ public RangesForEpochHolder rangesForEpochHolder()
public abstract void shutdown();
+ public abstract AsyncChain<Timestamp> maxAppliedFor(Seekables<?, ?>
keysOrRanges, Ranges slice);
Review Comment:
why would it not have the keys? Isn't the job of `submit(PreLoadContext)`
to make sure the keys are present (for key and ranges)?
I do think @belliottsmith didn't like me moving `maxConflict` to the safe
store... but keeping it in `CommandStore` made C* more complex, as we don't
have everything in-memory... so we are forced to push this logic into the
executor (aka `SafeCommandStore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
