bdeggleston commented on code in PR #49:
URL: https://github.com/apache/cassandra-accord/pull/49#discussion_r1228577942
##########
accord-core/src/main/java/accord/local/CommandStore.java:
##########
@@ -128,6 +128,8 @@ public RangesForEpochHolder rangesForEpochHolder()
public abstract void shutdown();
+ public abstract AsyncChain<Timestamp> maxAppliedFor(Seekables<?, ?>
keysOrRanges, Ranges slice);
Review Comment:
because FetchRequest is a read, which can be executed in 2 stages. The first
determines if the command is eligible to be executed. The second stage executes
the read. If the command can be executed, the second stage is started. If it's
not, the read waits for it to become eligible, then starts the second stage. In
this case where it's run in 2 parts, only the second part needs the ranges. If
the ranges were loaded as part of the first part we would be loading them but
unable to use them and/or have out of date data when performing the second stage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
