bdeggleston commented on code in PR #49:
URL: https://github.com/apache/cassandra-accord/pull/49#discussion_r1228465591
##########
accord-core/src/main/java/accord/local/CommandStore.java:
##########
@@ -128,6 +128,8 @@ public RangesForEpochHolder rangesForEpochHolder()
public abstract void shutdown();
+ public abstract AsyncChain<Timestamp> maxAppliedFor(Seekables<?, ?>
keysOrRanges, Ranges slice);
Review Comment:
I don't agree. The safe store you'd be calling couldn't be used for
maxApplied since it wouldn't have the keys in scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
