dcapwell commented on code in PR #49:
URL: https://github.com/apache/cassandra-accord/pull/49#discussion_r1231612872
##########
accord-core/src/main/java/accord/impl/InMemoryCommandStore.java:
##########
@@ -461,6 +461,20 @@ void update(Ranges add)
}
}
+ @Override
+ public AsyncChain<Timestamp> maxAppliedFor(Seekables<?, ?> keysOrRanges,
Ranges slice)
Review Comment:
This implementation doesn't look consistent with the Cassandra version...
1) we don't filter for write txn, so include non-write txn, can add `if
(command.txnId().rw() != Txn.Kind.Write) continue;`
2) we do `command.executeAt`, but Cassandra does `byId` aka `command.txnId()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
