belliottsmith commented on code in PR #49:
URL: https://github.com/apache/cassandra-accord/pull/49#discussion_r1229972815
##########
accord-core/src/main/java/accord/impl/InMemoryCommandStore.java:
##########
@@ -461,6 +461,19 @@ void update(Ranges add)
}
}
+ public AsyncChain<Timestamp> maxAppliedFor(Seekables<?, ?> keysOrRanges,
Ranges slice)
+ {
+ Seekables<?, ?> sliced = keysOrRanges.slice(slice, Minimal);
+ Timestamp timestamp = Timestamp.NONE;
+ for (GlobalCommand globalCommand : commands.values())
Review Comment:
I was mistaken too though, I don’t think this is sufficient to propagate
maxApplied reliably, as the range transaction that is used for bootstrap may be
less than a propagated command. We probably want an additional register to
store a timestamp to propagate. Perhaps I’ll fold that into my truncation patch
as we also need one for tracking timestamps that have been truncated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
