dcapwell commented on code in PR #49:
URL: https://github.com/apache/cassandra-accord/pull/49#discussion_r1232629541
##########
accord-core/src/main/java/accord/impl/InMemoryCommandStore.java:
##########
@@ -461,6 +461,20 @@ void update(Ranges add)
}
}
+ @Override
+ public AsyncChain<Timestamp> maxAppliedFor(Seekables<?, ?> keysOrRanges,
Ranges slice)
Review Comment:
looking at the bootstrap code, I think we only care about write txn, so #1
makes sense to change in this class... but executeAt I think is more correct in
this context, so prob need C* to be changed...
One thing that bugs me, the docs implies that the returned timestamp must be
from the dependencies list, but I don't see any logic to enforce or care about
that, so is it just a wording issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
