belliottsmith commented on code in PR #50:
URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1239484137


##########
accord-core/src/main/java/accord/utils/ReducingIntervalMap.java:
##########
@@ -44,34 +45,39 @@ public class ReducingIntervalMap<K extends Comparable<? 
super K>, V>
 
     // for simplicity at construction, we permit this to be overridden by the 
first insertion
     final boolean inclusiveEnds;
-    final K[] ends;
+    // starts is 1 longer than values, so that starts[0] == start of values[0]
+    final K[] starts;
     final V[] values;
 
-    public ReducingIntervalMap(V value)
+    public ReducingIntervalMap()
     {
-        this(false, value);
+        this(false);
     }
 
-    public ReducingIntervalMap(boolean inclusiveEnds, V value)
+    public ReducingIntervalMap(boolean inclusiveEnds)

Review Comment:
   This class is tested via `ReducingRangeMap`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to