belliottsmith commented on code in PR #50: URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1239491912
########## accord-core/src/main/java/accord/local/Commands.java: ########## @@ -50,36 +48,39 @@ import accord.primitives.Unseekables; import accord.primitives.Writes; import accord.utils.Invariants; -import accord.utils.SortedArrays; import accord.utils.async.AsyncChain; import accord.utils.async.AsyncChains; -import net.nicoulaj.compilecommand.annotations.Inline; -import javax.annotation.Nonnull; import javax.annotation.Nullable; import static accord.api.ProgressLog.ProgressShard.Home; import static accord.api.ProgressLog.ProgressShard.Local; import static accord.api.ProgressLog.ProgressShard.No; import static accord.api.ProgressLog.ProgressShard.UnmanagedHome; import static accord.api.ProgressLog.ProgressShard.Unsure; +import static accord.local.Command.Truncated.truncated; import static accord.local.Commands.EnsureAction.Add; import static accord.local.Commands.EnsureAction.Check; import static accord.local.Commands.EnsureAction.Ignore; import static accord.local.Commands.EnsureAction.Set; import static accord.local.Commands.EnsureAction.TrySet; +import static accord.local.RedundantStatus.LIVE; +import static accord.local.SaveStatus.Uninitialised; import static accord.local.Status.Accepted; import static accord.local.Status.AcceptedInvalidate; import static accord.local.Status.Applied; +import static accord.local.Status.Applying; import static accord.local.Status.Committed; import static accord.local.Status.Durability; +import static accord.local.Status.Durability.Universal; import static accord.local.Status.Invalidated; import static accord.local.Status.Known; import static accord.local.Status.Known.ExecuteAtOnly; +import static accord.local.Status.NotDefined; import static accord.local.Status.PreApplied; import static accord.local.Status.PreCommitted; import static accord.local.Status.ReadyToExecute; -import static accord.primitives.Routables.Slice.Minimal; +import static accord.local.Status.Truncated; import static accord.primitives.Route.isFullRoute; public class Commands Review Comment: If we were to supply the wrong command we would have a serious bug, whether or not the TxnId matches? So I don't think this is a good reason, but I don't mind not supplying both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
