belliottsmith commented on code in PR #50:
URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1239519825
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -885,7 +963,7 @@ public void accept(SafeCommandStore safeStore)
if (prev != null)
{
- if (cur.has(until) || (cur.hasBeen(PreCommitted) &&
cur.executeAt().compareTo(prev.executeAt()) > 0))
+ if (cur.has(until) || cur.hasBeen(Truncated) ||
(cur.hasBeen(PreCommitted) && cur.executeAt().compareTo(prev.executeAt()) > 0
&& !prev.txnId().rw().awaitsFutureDeps()))
Review Comment:
Invalidated does not logically have an executeAt, and does not execute. This
may have been a bug before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
