belliottsmith commented on code in PR #50:
URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1239496650
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -610,247 +665,236 @@ private static boolean maybeExecute(SafeCommandStore
safeStore, SafeCommand safe
}
}
- protected static WaitingOn populateWaitingOn(SafeCommandStore safeStore,
TxnId txnId, Timestamp executeAt, PartialDeps partialDeps)
+ protected static WaitingOn initialiseWaitingOn(SafeCommandStore safeStore,
TxnId waitingId, Timestamp executeWaitingAt, PartialDeps partialDeps, Route<?>
route)
{
- Ranges ranges = applyRanges(safeStore, executeAt);
- if (ranges.isEmpty())
- return WaitingOn.EMPTY;
-
- return populateWaitingOn(safeStore, ranges, txnId, executeAt,
partialDeps);
+ Unseekables<?> executionParticipants =
route.participants().slice(safeStore.ranges().allAt(executeWaitingAt));
+ WaitingOn.Update update = new WaitingOn.Update(executionParticipants,
partialDeps);
Review Comment:
Ah, yes. I think this was because the conditional breakpoint was slowing
things down too much. This is fine, and correct if there are no execution
participants. I will delete this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
