belliottsmith commented on code in PR #50: URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1254383722
########## accord-core/src/main/java/accord/messages/QueryDurableBefore.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package accord.messages; + +import accord.local.PreLoadContext; +import accord.local.DurableBefore; +import accord.local.SafeCommandStore; +import accord.utils.MapReduceConsume; + +public class QueryDurableBefore extends AbstractEpochRequest<QueryDurableBefore.DurableBeforeReply> + implements Request, PreLoadContext, MapReduceConsume<SafeCommandStore, QueryDurableBefore.DurableBeforeReply> +{ + final long epoch; + public QueryDurableBefore(long epoch) + { + super(null); + this.epoch = epoch; + } + + @Override + public void process() + { + node.mapReduceConsumeAllLocal(this, this); + } + + @Override + public DurableBeforeReply apply(SafeCommandStore safeStore) + { + return new DurableBeforeReply(safeStore.commandStore().durableBefore()); + } + + @Override + public DurableBeforeReply reduce(DurableBeforeReply r1, DurableBeforeReply r2) + { + return new DurableBeforeReply(DurableBefore.merge(r1.durableBeforeMap, r2.durableBeforeMap)); + } + + @Override + public void accept(DurableBeforeReply ok, Throwable failure) + { + node.reply(replyTo, replyContext, ok); Review Comment: This is probably better to have in node.reply tbh, since this isn't the only place to cause problems -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
