belliottsmith commented on code in PR #50: URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1254772638
########## accord-core/src/main/java/accord/utils/SimpleBitSet.java: ########## @@ -0,0 +1,348 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package accord.utils; + +import java.util.Arrays; + +import static java.lang.Long.highestOneBit; +import static java.lang.Long.lowestOneBit; +import static java.lang.Long.numberOfTrailingZeros; + +public class SimpleBitSet Review Comment: Thanks. I get where you’re coming from, though I'm personally not convinced it would have been much smoother - there aren't _many_ custom data structures of the kind discussed. Adapting poorly-fitting data structures requires as much mental gymnastics in my experience - just in the places you contort them, as you map between what you intend and what they support cleanly, which only gets worse as the delta widens. You usually end up much less efficient in memory and cpu for your efforts to boot. Making your core data structures properly match the core functionality is much simpler IME, especially in the long run. But, each to their own - it is hardly an objective science. In this particular case, I reached initially for `BitSet`, but found it wanting. I think the other main case we could perhaps point to would be `SortedArrays` - which is all functionality we would have had to implement bespoke in *some* way, just using different primitives and probably requiring plenty of squinting all the same. But let’s have a retrospective as the project winds down to go over some of the design choices and see if there are any places we could have made better choices and that perhaps introduced unnecessary extra costs, I have no doubt they are there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
