belliottsmith commented on code in PR #50:
URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1254385729
##########
accord-core/src/main/java/accord/messages/ReadTxnData.java:
##########
@@ -218,6 +232,14 @@ void maybeRead(SafeCommandStore safeStore, SafeCommand
safeCommand)
}
}
+ @Override
+ protected synchronized void readComplete(CommandStore commandStore,
@Nullable Data result, @Nullable Ranges unavailable)
+ {
+ // TODO (expected): lots of undesirable costs associated with the
obsoletion tracker
+// commandStore.execute(contextFor(txnId), safeStore ->
safeStore.command(txnId).removeListener(obsoleteTracker));
Review Comment:
Why? We probably want to address this if we can. I can reword it. I have for
now commented out the logic that unregisters the obsoletion tracker, as it was
incurring significant costs. Ideally we want to be able to manage these more
cheaply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
