bdeggleston commented on code in PR #50: URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1254755674
########## accord-core/src/main/java/accord/utils/SimpleBitSet.java: ########## @@ -0,0 +1,348 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package accord.utils; + +import java.util.Arrays; + +import static java.lang.Long.highestOneBit; +import static java.lang.Long.lowestOneBit; +import static java.lang.Long.numberOfTrailingZeros; + +public class SimpleBitSet Review Comment: > Wasting significant effort debating this kind of ideological point is also highly counterproductive, IMO. Hey it takes two I generally prefer stdlib data structures wherever possible, even if the fit is a little awkward. In this case, the lack of a copy constructor is a pretty credible justification, given the frequent switching between mutable and immutable instances. That said, in retrospect, I think we’ve spent too much time writing new data structures for accord. I understand the motivation, but they’re a real drag on review velocity, since you’re not only painstakingly reasoning about protocol changes, but also painstakingly thinking through large swaths of array math. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
