michaelsembwever commented on code in PR #2506:
URL: https://github.com/apache/cassandra/pull/2506#discussion_r1272222253
##########
src/java/org/apache/cassandra/service/pager/PagingState.java:
##########
@@ -402,7 +402,7 @@ public static RowMark create(TableMetadata metadata, Row
row, ProtocolVersion pr
{
// We froze the serialization version to 3.0 as we need to
make this this doesn't change (that is, it has to be
// fix for a given version of the protocol).
- mark = Clustering.serializer.serialize(row.clustering(),
MessagingService.VERSION_30, makeClusteringTypes(metadata));
+ mark = Clustering.serializer.serialize(row.clustering(),
MessagingService.VERSION_40, makeClusteringTypes(metadata));
Review Comment:
what about
```
// We froze the serialization version to VERSION_30 as we need to make sure
this this doesn't change
// It got bumped to VERSION_40 when VERSION_30 got dropped, knowing it
didn't change and the latter is not used in a 5.x cluster
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
