michaelsembwever commented on code in PR #2506:
URL: https://github.com/apache/cassandra/pull/2506#discussion_r1272246322
##########
src/java/org/apache/cassandra/db/filter/ColumnFilter.java:
##########
@@ -1004,8 +1003,6 @@ private void
serializeRegularAndStaticColumns(RegularAndStaticColumns regularAnd
public ColumnFilter deserialize(DataInputPlus in, int version,
TableMetadata metadata) throws IOException
{
int header = in.readUnsignedByte();
- // The meaning of isFetchAll is actually different for pre-4.0
versions and for 4.0+ versions
- // In 4.0+ it meant is fetch all regulars
Review Comment:
what about `isFetchAll` in `Builder.build()` ? and the comments in that
method …?
if we are removing the three `isUpgradingFromVersionLowerThan*()` methods,
there's a few comments that need fixing. is this in scope?
##########
src/java/org/apache/cassandra/db/filter/ColumnFilter.java:
##########
@@ -1004,8 +1003,6 @@ private void
serializeRegularAndStaticColumns(RegularAndStaticColumns regularAnd
public ColumnFilter deserialize(DataInputPlus in, int version,
TableMetadata metadata) throws IOException
{
int header = in.readUnsignedByte();
- // The meaning of isFetchAll is actually different for pre-4.0
versions and for 4.0+ versions
- // In 4.0+ it meant is fetch all regulars
Review Comment:
what about `isFetchAll` in `Builder.build()` ? and the comments in that
method …?
if we are removing the three `isUpgradingFromVersionLowerThan*()` methods,
there's a few comments that need fixing. is this in scope?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
