belliottsmith commented on code in PR #57:
URL: https://github.com/apache/cassandra-accord/pull/57#discussion_r1301838133
##########
accord-core/src/main/java/accord/impl/AbstractConfigurationService.java:
##########
@@ -269,6 +269,13 @@ public synchronized void reportTopology(Topology topology,
boolean startSync)
}
long lastAcked = epochs.lastAcknowledged;
+ // TODO (now, review): lastAcked == 0, lastReceived = 2
+ // if we wait for epoch=1.acknowledge the test seems to wait
forever... looks like burn test doesn't ack epoch=1
+ if (lastAcked == 0 && lastReceived > 0)
Review Comment:
Do you have the SHA that caused this? It doesn't quite track to me what
we're doing here. If the burn test wasn't ACKing epoch 1, I don't see how this
change would help either, so would be great to debug an example so can
understand the cause/fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
