belliottsmith commented on code in PR #57:
URL: https://github.com/apache/cassandra-accord/pull/57#discussion_r1301842440
##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -172,7 +172,10 @@ public Node(Id id, MessageSink messageSink,
ConfigurationService configService,
// TODO (cleanup, testing): remove, only used by Maelstrom
public AsyncResult<Void> start()
{
- return onTopologyUpdateInternal(configService.currentTopology(),
false).metadata;
+ EpochReady ready =
onTopologyUpdateInternal(configService.currentTopology(), false);
+ ready.coordination.addCallback(() ->
this.topology.onEpochSyncComplete(id, topology.epoch()));
+ configService.acknowledgeEpoch(ready);
Review Comment:
Should we be doing this on every node start? If this is only used for test
purposes, perhaps we should extend `Node` for testing, or at least mark
VisibleForTesting. But if we start simulating node stop/start I'm not sure if
this makes sense for testing either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
