skoppu22 commented on code in PR #2648:
URL: https://github.com/apache/cassandra/pull/2648#discussion_r1321766712
##########
src/java/org/apache/cassandra/tools/nodetool/InvalidateCIDRPermissionsCache.java:
##########
@@ -39,8 +39,8 @@ public void execute(NodeProbe probe)
{
if (args.isEmpty())
{
- probe.invalidateCidrPermissionsCache("");
- probe.output().out.println("Invalidated CIDR permissions cache");
+ if(probe.invalidateCidrPermissionsCache(""))
Review Comment:
This change doesn't hurt, but works fine without this change as well.
Invalidating entire CIDR permissions cache doesn't go through
invalidateCidrPermissions(String roleName) we are changing above. i.e, we
always get return value true here.
```
@Override
public boolean invalidateCidrPermissionsCache(String roleName)
{
if (roleName == null || roleName.isEmpty())
{
cidrPermissionsCache.invalidate();
return true;
}
return cidrPermissionsCache.invalidateCidrPermissions(roleName);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
