ekaterinadimitrova2 commented on code in PR #2648:
URL: https://github.com/apache/cassandra/pull/2648#discussion_r1321769440
##########
src/java/org/apache/cassandra/tools/nodetool/InvalidateCIDRPermissionsCache.java:
##########
@@ -39,8 +39,8 @@ public void execute(NodeProbe probe)
{
if (args.isEmpty())
{
- probe.invalidateCidrPermissionsCache("");
- probe.output().out.println("Invalidated CIDR permissions cache");
+ if(probe.invalidateCidrPermissionsCache(""))
Review Comment:
But `return cidrPermissionsCache.invalidateCidrPermissions(roleName);` can
return false?
```
public boolean invalidateCidrPermissions(String roleName)
{
if (cache.getIfPresent(RoleResource.role(roleName)) == null)
return false;
invalidate(RoleResource.role(roleName));
return true;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
