ekaterinadimitrova2 commented on code in PR #2648:
URL: https://github.com/apache/cassandra/pull/2648#discussion_r1321867173


##########
src/java/org/apache/cassandra/auth/CassandraCIDRAuthorizer.java:
##########
@@ -154,4 +154,10 @@ public boolean hasAccessFromIp(RoleResource role, 
InetAddress ipAddress)
                                                           
TimeUnit.NANOSECONDS);
         return hasAccess;
     }
+
+    @VisibleForTesting
+    public boolean has(RoleResource role)

Review Comment:
   I am fine if we do not use that method, but how do we confirm the 
validation? The tests are passing with/without the fix. I was looking to cover 
the invalidation fully and ensure that we do not regress in the future. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to